Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table search filter #683

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Conversation

KristinAoki
Copy link
Member

JIRA Ticket: TNL-11207

I get an error if typing anything into search box. Typing one letter leads to error page.
image

When making the updates to the filter function for display chips and modal, the search bar's filter capabilities were not accounted for. The search bar filters are not associated with a specific column, so when using it and error was thrown because the matching column could not be found. The filter functions now account for when there is not an associated column for the search filter.

Testing

  1. Navigate to the Files page.
  2. Type something in the search bar
  3. A chip with a matching string should appear
  4. Files should filter as expected
  5. Open the Sort and filter modal
  6. Select one of the filters and apply
  7. Chips should show selected filter and search string
  8. Remove each of the chip individually
  9. All the files should be listed
  • repeat for the videos page

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c7ea1f) 88.32% compared to head (15caa70) 88.37%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #683      +/-   ##
==========================================
+ Coverage   88.32%   88.37%   +0.05%     
==========================================
  Files         420      420              
  Lines        6526     6540      +14     
  Branches     1408     1416       +8     
==========================================
+ Hits         5764     5780      +16     
+ Misses        737      735       -2     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@connorhaugh connorhaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the good tests and test instructions! LGTM

@KristinAoki KristinAoki merged commit ce9db57 into master Nov 14, 2023
5 checks passed
@KristinAoki KristinAoki deleted the KristinAoki/fix-table-search-filter branch November 14, 2023 18:21
Ian2012 pushed a commit to eduNEXT/frontend-app-course-authoring that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants