Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: total file count update on add and delete #681

Merged

Conversation

KristinAoki
Copy link
Member

JIRA Ticket: TNL-10958

I had 29 files, uploaded 5, and then had 32 files. But it showed this:
image

Testing

  1. Navigate to the Videos Page
  2. Add multiple videos
  3. Check that row status count equals the expected amount
  4. Delete at least two videos
  5. Check that row status count equals the expected amount

*repeat for the Files page

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e41efba) 87.97% compared to head (ddfa02a) 87.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #681      +/-   ##
==========================================
- Coverage   87.97%   87.95%   -0.02%     
==========================================
  Files         415      415              
  Lines        6396     6387       -9     
  Branches     1379     1379              
==========================================
- Hits         5627     5618       -9     
  Misses        745      745              
  Partials       24       24              
Files Coverage Δ
src/files-and-videos/files-page/FilesPage.jsx 100.00% <100.00%> (ø)
src/files-and-videos/files-page/data/slice.js 94.73% <ø> (-0.27%) ⬇️
src/files-and-videos/files-page/data/thunks.js 100.00% <100.00%> (ø)
src/files-and-videos/generic/FileTable.jsx 97.10% <100.00%> (+0.04%) ⬆️
src/files-and-videos/videos-page/VideosPage.jsx 100.00% <100.00%> (ø)
src/files-and-videos/videos-page/data/slice.js 95.83% <ø> (-0.17%) ⬇️
src/files-and-videos/videos-page/data/thunks.js 98.11% <100.00%> (-0.04%) ⬇️
...-videos/videos-page/factories/mockApiResponses.jsx 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KristinAoki KristinAoki merged commit 2fbb490 into master Nov 13, 2023
5 checks passed
@KristinAoki KristinAoki deleted the KristinAoki/fix-total-file-count-on-add-and-delete branch November 13, 2023 19:46
Ian2012 pushed a commit to eduNEXT/frontend-app-course-authoring that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants