Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: opt out is not supported by lti proctoring #673

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

zacharis278
Copy link
Contributor

This toggle does nothing if an LTI tool is selected. We should hide it in that case.

2U JIRA: COSMO-56

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3dac6aa) 88.19% compared to head (fa4a022) 87.97%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #673      +/-   ##
==========================================
- Coverage   88.19%   87.97%   -0.23%     
==========================================
  Files         417      415       -2     
  Lines        6600     6396     -204     
  Branches     1430     1379      -51     
==========================================
- Hits         5821     5627     -194     
+ Misses        755      745      -10     
  Partials       24       24              
Files Coverage Δ
src/pages-and-resources/proctoring/Settings.jsx 97.94% <100.00%> (ø)

... and 63 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharis278 zacharis278 changed the title feat: opt out is not supported by lti proctoring fix: opt out is not supported by lti proctoring Nov 9, 2023
@zacharis278 zacharis278 force-pushed the zhancock/disable-opt-out branch from 98bef89 to fa4a022 Compare November 9, 2023 13:57
Copy link
Member

@varshamenon4 varshamenon4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! (Just rerunning codecov checks because it shows as failing for some reason - but I think it might just be because it wasn't run recently)

@zacharis278 zacharis278 merged commit e41efba into master Nov 13, 2023
4 of 5 checks passed
@zacharis278 zacharis278 deleted the zhancock/disable-opt-out branch November 13, 2023 14:14
Ian2012 pushed a commit to eduNEXT/frontend-app-course-authoring that referenced this pull request Nov 15, 2023
This toggle does nothing if an LTI tool is selected. We should hide it in that case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants