refactor: files-and-videos folder #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #672 +/- ##
==========================================
- Coverage 88.19% 88.19% -0.01%
==========================================
Files 417 418 +1
Lines 6600 6598 -2
Branches 1430 1427 -3
==========================================
- Hits 5821 5819 -2
Misses 755 755
Partials 24 24
☔ View full report in Codecov by Sentry. |
jesperhodge
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
I left one little request for renaming, but everything looks great. The folder structure is really clear to understand, and it's very consistent with the rest of the repo (especially the 'generics' folder). It's nicely scalable now so that we can organize files the same way in other folders and everything is still consistent.
There was a problem hiding this comment.
This is better named constants.js because this is the naming we use everywhere else in the project
KristinAoki
deleted the
KristinAoki/refactor-files-and-videos-folder-structure
branch
Ian2012
pushed a commit
to eduNEXT/frontend-app-course-authoring
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.