Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change filter status text #657

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

jesperhodge
Copy link
Member

Changed the filter status text on the files and uploads table to display also the number of files, even when a filter is applied.

https://2u-internal.atlassian.net/browse/TNL-11086 (internal ticket)

I just copied most of paragon's FilterStatus component, made some adjustments, and then overrode the default component.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (378b0e9) 86.85% compared to head (216d4d1) 86.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #657      +/-   ##
==========================================
- Coverage   86.85%   86.67%   -0.19%     
==========================================
  Files         388      389       +1     
  Lines        5783     5799      +16     
  Branches     1267     1274       +7     
==========================================
+ Hits         5023     5026       +3     
- Misses        735      748      +13     
  Partials       25       25              
Files Coverage Δ
src/files-and-uploads/FilesAndUploads.jsx 98.71% <ø> (ø)
...iles-and-uploads/table-components/FilterStatus.jsx 18.75% <18.75%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesperhodge
Copy link
Member Author

Merged since the component is mostly copied from paragon and tests are sufficient.

@jesperhodge jesperhodge merged commit 221fcf7 into master Oct 27, 2023
3 of 5 checks passed
@jesperhodge jesperhodge deleted the feat--change-filter-status-text-on-files-table branch October 27, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants