-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Missed favicon in Safari #633
fix: Missed favicon in Safari #633
Conversation
Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #633 +/- ##
=======================================
Coverage 86.06% 86.06%
=======================================
Files 383 383
Lines 5757 5757
Branches 1268 1268
=======================================
Hits 4955 4955
Misses 777 777
Partials 25 25 ☔ View full report in Codecov by Sentry. |
Hi @openedx/teaching-and-learning! Would someone be able to please review / merge this for us? Thanks! |
@Lunyachek 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
The favicon is not currently displaying in Safari. After our investigation, we have found a way to fix it. We used the same approach as what was done in the account mfe. We changed the favicon inclusion in the index.html file, and now the favicon is being displayed in Safari.