Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: course updates UI bugs #606

Merged
merged 5 commits into from
Sep 22, 2023

Conversation

KristinAoki
Copy link
Member

JIRA Ticket: TNL-11025

Test the following items

  • Update “Add newUpdate” button to use variant="primary"
  • Change edit and delete buttons to be icon buttons
  • Change confirmation text in delete from “ok” to “delete”
  • Changer header color of confirmation delete modal
  • fix width of page, currently overflows the page horizontally on laptop screen
  • make error icon color danger-500 (invalid date for update)

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.12% 🎉

Comparison is base (6f238bd) 86.32% compared to head (850cb7c) 86.45%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #606      +/-   ##
==========================================
+ Coverage   86.32%   86.45%   +0.12%     
==========================================
  Files         329      372      +43     
  Lines        5091     5580     +489     
  Branches     1115     1235     +120     
==========================================
+ Hits         4395     4824     +429     
- Misses        674      732      +58     
- Partials       22       24       +2     
Files Changed Coverage Δ
src/course-updates/CourseUpdates.jsx 93.10% <ø> (ø)
.../course-updates/course-handouts/CourseHandouts.jsx 100.00% <ø> (ø)
src/course-updates/course-update/CourseUpdate.jsx 100.00% <ø> (ø)
src/course-updates/delete-modal/DeleteModal.jsx 100.00% <ø> (ø)
src/course-updates/delete-modal/messages.js 100.00% <ø> (ø)
src/course-updates/messages.js 100.00% <ø> (ø)
src/course-updates/update-form/UpdateForm.jsx 84.21% <ø> (ø)

... and 55 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KristinAoki KristinAoki merged commit ef9633a into master Sep 22, 2023
@KristinAoki KristinAoki deleted the KristinAoki/fix-course-updates-ui-bugs branch September 22, 2023 19:51
snglth pushed a commit to Abstract-Tech/community-theme-course-authoring that referenced this pull request Jan 9, 2024
* fix: change edit and delete buttons to icons

* fix: padding and button color

* fix: delete buttons and variant

* fix: date error icon color

* fix: page explanation text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants