-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update toggle state based on api response #604
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundasnoreen12
force-pushed
the
sundas/INF-1074
branch
from
September 18, 2023 10:37
c4d087a
to
fa1c846
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #604 +/- ##
==========================================
+ Coverage 86.32% 86.45% +0.12%
==========================================
Files 329 372 +43
Lines 5091 5580 +489
Branches 1115 1235 +120
==========================================
+ Hits 4395 4824 +429
- Misses 674 732 +58
- Partials 22 24 +2
☔ View full report in Codecov by Sentry. |
sundasnoreen12
requested review from
awais-ansari,
asadazam93,
AhtishamShahid and
muhammadadeeltajamul
September 18, 2023 10:53
sundasnoreen12
force-pushed
the
sundas/INF-1074
branch
from
September 20, 2023 11:49
fa1c846
to
84c0c80
Compare
awais-ansari
requested changes
Sep 21, 2023
sundasnoreen12
force-pushed
the
sundas/INF-1074
branch
from
September 22, 2023 06:18
5c5c33c
to
ef287a9
Compare
awais-ansari
approved these changes
Sep 22, 2023
muhammadadeeltajamul
approved these changes
Sep 22, 2023
mariajgrimaldi
pushed a commit
to eduNEXT/frontend-app-course-authoring
that referenced
this pull request
Dec 11, 2023
* fix: update toggle state based on api response * refactor: added statefulbutton instead of button --------- Co-authored-by: SundasNoreen <[email protected]>
mariajgrimaldi
pushed a commit
to eduNEXT/frontend-app-course-authoring
that referenced
this pull request
Dec 11, 2023
* fix: update toggle state based on api response * refactor: added statefulbutton instead of button --------- Co-authored-by: SundasNoreen <[email protected]>
snglth
pushed a commit
to Abstract-Tech/community-theme-course-authoring
that referenced
this pull request
Jan 9, 2024
* fix: update toggle state based on api response * refactor: added statefulbutton instead of button --------- Co-authored-by: SundasNoreen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INF-1074
Description
Updated the toggle state of Hide discussion tab on API response.