feat: update header to be keyboard accessible #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristinAoki
requested review from
kenclary,
jesperhodge,
connorhaugh and
rayzhou-bit
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #597 +/- ##
==========================================
- Coverage 84.55% 83.96% -0.60%
==========================================
Files 307 312 +5
Lines 4993 5100 +107
Branches 1102 1126 +24
==========================================
+ Hits 4222 4282 +60
- Misses 747 771 +24
- Partials 24 47 +23
☔ View full report in Codecov by Sentry. |
snglth
pushed a commit
to Abstract-Tech/community-theme-course-authoring
that referenced
this pull request
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: TNL-10750
This PR resolves the menu overlap issue when changing between different menus in the header. Additionally this PR make the header keyboard accessible. The previous version of the header did not allow the Content, Settings, or Tools menus to be clickable/hoverable via the keyboard only. Lastly the PR makes the menus and button hover states consistent across all dropdown menus.
Testing