fix: reworked grading deadline #584
Conversation
|
Thanks for the pull request, @ruzniaievdm! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
the
open-source-contribution
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #584 +/- ##
==========================================
+ Coverage 84.63% 84.71% +0.07%
==========================================
Files 308 309 +1
Lines 5017 5043 +26
Branches 1103 1109 +6
==========================================
+ Hits 4246 4272 +26
Misses 747 747
Partials 24 24
☔ View full report in Codecov by Sentry. |
ruzniaievdm
force-pushed
the
ruzniaievdm/fix/reworked-grading-deadline
branch
from
943a2aa to
7874c72
Compare
|
Hi @ruzniaievdm! Is this ready for review? |
| export function timerValidation(inputStr, setShowSavePrompt, setIsError) { | ||
| const timePattern = /^\d{2,3}:\d{2}$/; | ||
|
|
||
| const isValid = timePattern.test(inputStr); | ||
| setShowSavePrompt(isValid); | ||
| setIsError(!isValid); | ||
|
|
||
| return isValid; | ||
| } |
There was a problem hiding this comment.
I am able to enter times that are not valid such as 12:65 and 32:45. Please add in checks for valid times based on 24-hour time (00:00 - 23:59).
There was a problem hiding this comment.
Thanks, Kristin
Added required validation
PKulkoRaccoonGang
force-pushed
the
ruzniaievdm/fix/reworked-grading-deadline
branch
from
6bd743f to
c4d018c
Compare
|
@ruzniaievdm 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description:
Аdditional bug fixes on the
Grading Page