Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: file info bugs #571

Merged
merged 2 commits into from
Aug 21, 2023
Merged

fix: file info bugs #571

merged 2 commits into from
Aug 21, 2023

Conversation

KristinAoki
Copy link
Member

JIRA Ticket: TNL-10953

This PR makes addresses the following ui bugs in the file info modal:

  1. Makes the file preview a fixed height and width
  2. Adjusts the date added to use the localized version of the time instead of utc
Screenshot 2023-08-17 at 2 10 46 PM Screenshot 2023-08-17 at 2 10 36 PM

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: +0.01% 🎉

Comparison is base (b65f4f2) 84.38% compared to head (e215835) 84.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
+ Coverage   84.38%   84.40%   +0.01%     
==========================================
  Files         259      259              
  Lines        4247     4252       +5     
  Branches      959      959              
==========================================
+ Hits         3584     3589       +5     
  Misses        639      639              
  Partials       24       24              
Files Changed Coverage Δ
src/files-and-uploads/FileThumbnail.jsx 77.77% <50.00%> (ø)
src/files-and-uploads/FileInfo.jsx 83.33% <100.00%> (+1.51%) ⬆️
src/files-and-uploads/data/utils.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KristinAoki KristinAoki merged commit be74de2 into master Aug 21, 2023
@KristinAoki KristinAoki deleted the KristinAoki/fix-file-info-bugs branch August 21, 2023 20:47
snglth pushed a commit to Abstract-Tech/community-theme-course-authoring that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants