feat: Created Course Team #564
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
mphilbrick211
added
the
needs test run
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #564 +/- ##
==========================================
+ Coverage 84.44% 84.45% +0.01%
==========================================
Files 259 278 +19
Lines 4314 4543 +229
Branches 974 1023 +49
==========================================
+ Hits 3643 3837 +194
- Misses 647 682 +35
Partials 24 24
☔ View full report in Codecov by Sentry. |
|
@vladislavkeblysh it looks like this PR has decreased code coverage, can you have a look? |
e0d
added
waiting on author
mphilbrick211
added
the
needs test run
* feat: 2u-185 init page * feat: 2u-185 add api and tests * feat: au-185 fix translates and styles * feat: au-185 clean slice * feat: au-185 fix course team tests * feat: 2u-185 fix bugs and styles * feat: 2u-185 fix sizes * feat: 2u-185 fix conditions * feat: 2u-185 fix typography * feat: 2u-185 fix indents * feat: 2u-185 fix indents and add js docs * feat: [2u-185 fix constants * feat: [2u-185] fix translates * feat: [2u-185] fix tests --------- Co-authored-by: Vladislav Keblysh <[email protected]> fix: Course team Internet connection alert (#38) * fix: [2u-283] add alert * fix: [2u-283] add indents --------- Co-authored-by: Vladislav Keblysh <[email protected]> feat: course team remove variablef from env fix: [2u-392] fix messages fix: [2u-392] fix translates feat: course team fix translates and env feat: course team fix env check
vladislavkeblysh
force-pushed
the
keblysh/course-team
branch
from
e0b290c to
0aec0e2
Compare
src/generic/FormikControl.jsx
Outdated
There was a problem hiding this comment.
Did you check how these changes impacted the other files. This component is also heavily used for pages and resources.
There was a problem hiding this comment.
I removed prop withErrorText as it turned out to be unnecessary.
src/i18n/messages/ru.json
Outdated
| @@ -641,4 +713,5 @@ | |||
| "course-authoring.grading-settings.assignment.alert.warning.title": "Warning: The number of {type} assignments defined here does not match the current number of {type} assignments in the course:", | |||
| "course-authoring.grading-settings.assignment.alert.success.title": "The number of {type} assignments in the course matches the number defined here.", | |||
| "course-authoring.grading-settings.assignment.type-name.error.message-2": "For grading to work, you must change all {initialAssignmentName} subsections to {value}" | |||
| "course-authoring.grading-settings.assignment.type-name.error.message-2": "For grading to work, you must change all {initialAssignmentName} subsections to {value}" | |||
There was a problem hiding this comment.
| "course-authoring.grading-settings.assignment.type-name.error.message-2": "For grading to work, you must change all {initialAssignmentName} subsections to {value}" |
This is a duplicate of the line above and causing a loading error
…ring into keblysh/course-team # Conflicts: # src/index.scss
|
@vladislavkeblysh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
Related PR to BE openedx/edx-platform#32782