Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken "Pages and Resources" page #446

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Fixed broken "Pages and Resources" page #446

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae91c0b
fix: updated AppHeader call
BilalQamar95 Feb 8, 2023
9e7e6ae
fix: AppHeader function signature changed to react component
BilalQamar95 Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/CourseAuthoringPage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const CourseAuthoringPage = ({ courseId, children }) => {
we shouldn't have the header and footer on these pages.
This functionality will be removed in TNL-9591 */}
{inProgress ? !pathname.includes('/editor/') && <Loading />
: <AppHeader courseNumber={courseNumber} courseOrg={courseOrg} courseTitle={courseTitle} courseId={courseId} />}
: AppHeader(courseNumber, courseOrg, courseTitle, courseId)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BilalQamar95 Rendering a React component by calling it as a function instead of rendering it with JSX (i.e., <AppHeader ... />) is an anti-pattern. I would recommend instead changing AppHeader's function signature to make it be a true React component (i.e., accepts a props object that may be destructured), rather than the existing function:

const AppHeader = ({ courseNumber, courseOrg, courseTitle, courseId }) => (...);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will update it

{children}
{!inProgress && <AppFooter />}
</div>
Expand Down