refactor: upgraded frontend-build version to v12

[BilalQamar95]

Ticket:
42: Upgrade eslint to v8.x

What changed?

• Updated frontend-build to v12 (Eslint was updated in frontend-build version resulting in it's version being bumped to v12. This PR updates frontend-build to reciprocate eslint version update)
• Resolved eslint issues

[codecov]

Codecov Report

Base: 74.26% // Head: 74.45% // Increases project coverage by +0.19% 🎉

Coverage data is based on head (96b6c3c) compared to base (9e9bac9).
Patch coverage: 86.02% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
+ Coverage   74.26%   74.45%   +0.19%     
==========================================
  Files         106      106              
  Lines        2067     2083      +16     
  Branches      512      514       +2     
==========================================
+ Hits         1535     1551      +16     
  Misses        504      504              
  Partials       28       28              

Impacted Files	Coverage Δ
src/CourseAuthoringRoutes.jsx	0.00% <0.00%> (ø)
src/generic/CollapsableEditor.jsx	100.00% <ø> (ø)
src/generic/ConfirmationPopup.jsx	66.66% <ø> (ø)
src/pages-and-resources/calculator/Settings.jsx	0.00% <0.00%> (ø)
...esources/discussions/app-list/SupportedFeature.jsx	100.00% <ø> (ø)
src/pages-and-resources/edxnotes/Settings.jsx	0.00% <0.00%> (ø)
src/pages-and-resources/progress/Settings.jsx	0.00% <0.00%> (ø)
src/pages-and-resources/teams/GroupEditor.jsx	0.00% <0.00%> (ø)
src/pages-and-resources/teams/Settings.jsx	0.00% <0.00%> (ø)
src/pages-and-resources/wiki/Settings.jsx	0.00% <0.00%> (ø)
... and 45 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[jristau1984]

Internal team ticket: https://2u-internal.atlassian.net/browse/TNL-10269

[arbrandes]

@jristau1984, looks like this is passing checks - anything else that needs to be done?

[jristau1984]

With such a big scope of change, some smoke tests in a lower environment would be ideal. After/barring that, just please let our on-call know you plan to merge. Thanks!

[arbrandes]

@jristau1984, my plan is to press the merge button here tomorrow morning.

[jristau1984]

Sounds good. Flagging @connorhaugh as on-call for the week.

[jristau1984]

This change appears to have broken the Pages an Resources pages. 2U-internal ticket: https://2u-internal.atlassian.net/browse/TNL-10439.

This will be triaged and likely reverted to ensure our pipeline can be re-enabled. @bszabo is now on-call, and will be fielding this effort.

[arbrandes]

@jristau1984, that's unfortunate. Do we have any details regarding what exactly is broken and how, by any chance?

[jristau1984]

@arbrandes - This is the information we know at this time, since our current SOP is to triage and revert rather than dig into root cause.

Steps to repro:

1. Navigate to a course’s Pages and Resources page in devstack or Stage env (Stage example: https://course-authoring.stage.edx.org/course/course-v1:edx+jrr101+jrr101_1/pages-and-resources)
2. See the Error page/"Try Again" button

Error: Objects are not valid as a React child (found: object with keys {}). If you meant to render a collection of children, use an array instead.

Please let us know if we can be of further assistance!

[BilalQamar95]

@jristau1984 The error message is indicating that an object is being rendered as a child component, I have tracked the issue & it is coming from CourseAuthoringPage, due to changes made in this PR. There may be some issue in the implementation of AppHeader component. It could be that some prop or component state is an object instead of a valid React child component. Since the revert has not been merged yet, I have fixed the issue, here is a PR for it with the fix.

[arbrandes]

Thanks for fixing this, @BilalQamar95!