refactor: added env variable for progress graph #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xitij2000
reviewed
Sep 22, 2021
| ) | ||
| ({ handleChange, handleBlur, values }) => { | ||
| let formSwitch = null; | ||
| if (process.env.ENABLE_PROGRESS_GRAPH_SETTINGS === 'true') { |
There was a problem hiding this comment.
You should merge this setting with the others in main index file inside mergeConfig and then you can load it here from the AppContext or using getConfig.
There was a problem hiding this comment.
Thanks for the suggestion, I have updated the code.
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
==========================================
- Coverage 70.49% 70.30% -0.19%
==========================================
Files 86 86
Lines 1481 1485 +4
Branches 323 327 +4
==========================================
Hits 1044 1044
- Misses 428 432 +4
Partials 9 9
Continue to review full report at Codecov.
|
mehaknasir
reviewed
Sep 23, 2021
mehaknasir
approved these changes
Sep 23, 2021
awaisdar001
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openedx.atlassian.net/browse/TNL-8700
Added env variable to toggle progress graph settings