Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: view live button added to pages and resources screen #161

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

mehaknasir
Copy link
Contributor

@mehaknasir mehaknasir commented Jul 14, 2021

Ticket ID: TNL-8515
-view live button is added to pages and resources screen according to the requirement given in the ticket
Screen after adding view live button
Screenshot 2021-07-15 at 4 35 04 PM

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2021

Codecov Report

Merging #161 (1121195) into master (12c81b2) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage   72.62%   72.49%   -0.14%     
==========================================
  Files          75       75              
  Lines        1107     1109       +2     
  Branches      216      216              
==========================================
  Hits          804      804              
- Misses        298      300       +2     
  Partials        5        5              
Impacted Files Coverage Δ
src/pages-and-resources/PagesAndResources.jsx 4.54% <0.00%> (-0.46%) ⬇️
src/pages-and-resources/messages.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12c81b2...1121195. Read the comment docs.

Copy link
Contributor

@awais-ansari awais-ansari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehaknasir mehaknasir merged commit 12ae7a6 into master Jul 15, 2021
@mehaknasir mehaknasir deleted the TNL-8515 branch July 15, 2021 15:47
rpenido pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Jan 2, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
bradenmacdonald pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Aug 9, 2024
* feat: header overlap content when scrolling down
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants