test: fix contentContainer test

[dcoa]

This PR fixes the testing after the merge of #1458

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.04%. Comparing base (ba48a27) to head (da054ba).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1516      +/-   ##
==========================================
- Coverage   93.04%   93.04%   -0.01%     
==========================================
  Files        1048     1049       +1     
  Lines       20544    20582      +38     
  Branches     4363     4445      +82     
==========================================
+ Hits        19116    19151      +35     
- Misses       1358     1359       +1     
- Partials       70       72       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[bradenmacdonald]

Merging manually since there is something wrong with the cla check, but I know @dcoa is authorized, and all the other checks have passed.

[openedx-webhooks]

Thanks for the pull request, @dcoa!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[PKulkoRaccoonGang]

@dcoa perhaps the error in the master that we now have on the Schedule and Details page is also related to the change of fetchImages to fetchCourseImages. Can you take a look?

[dcoa]

I don't have exactly the same error message

but I can tell the error comes from this change

frontend-app-authoring/src/editors/sharedComponents/TinyMceWidget/index.jsx

Line 58 in 66577b0

{!isLibraryV1Key(learningContextId) && (

Previously the line was

      {!isLibrary && (

And Schedule and Details pass the prop (isLibrary as true) so the ImageUploadModal is skip and the error is not displayed

I think there should be a different prop, I mean, Schedule and Details is not a library is part of courses.

How to test

• To prove the point I checkout master branch to a commit behind the changes introduced by the TinyMCE image support for libraries.
• Remove the line https://github.com/openedx/frontend-app-authoring/blob/master/src/generic/WysiwygEditor.jsx#L62
• The same error is displayed

I would like to ask you @PKulkoRaccoonGang if you can try in your environment and check if the assumption described is right.

Solutions

A possible solution could be pass a new prop different to isLibrary to skip the modal (Rename isLibrary for enableImageUpload).

As well as you thoughts about a new prop.

Thanks

[bradenmacdonald]

A possible solution could be pass a new prop different to isLibrary to skip the modal (Rename isLibrary for enableImageUpload).

@dcoa That makes sense to me. If this is broken on master and affecting edx.org please make sure we fix it ASAP. It's probably better to ping people on Slack or make a fix proactively.