Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: hide transcripts in video preview for library #1459

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

navinkarkera
Copy link
Contributor

@navinkarkera navinkarkera commented Nov 4, 2024

Description

Fixes: #1453

Supporting information

Testing instructions

  • Check transcripts in video editor preview in both course and libraries.
  • The transcripts part in preview should only be visible for courses.

@openedx-webhooks
Copy link

openedx-webhooks commented Nov 4, 2024

Thanks for the pull request, @navinkarkera!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.27%. Comparing base (fc94667) to head (a9b6bb7).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1459   +/-   ##
=======================================
  Coverage   93.27%   93.27%           
=======================================
  Files        1052     1052           
  Lines       20496    20498    +2     
  Branches     4393     4310   -83     
=======================================
+ Hits        19118    19120    +2     
- Misses       1315     1318    +3     
+ Partials       63       60    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@navinkarkera navinkarkera marked this pull request as ready for review November 4, 2024 07:46
@navinkarkera navinkarkera requested a review from a team as a code owner November 4, 2024 07:46
blockTitle="some title"
thumbnail=""
/>,
).snapshot).toMatchSnapshot();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is no longer advisable to use snapshots. If these are new tests, I recommend using React Testing Library: render(), screen, etc. Then you can test whether or not the transcript component is present more directly and descriptively.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisChV Done.

@navinkarkera navinkarkera force-pushed the navin/hide-transcripts-for-lib branch from 48124d3 to a9b6bb7 Compare November 5, 2024 05:18
@navinkarkera navinkarkera requested a review from ChrisChV November 5, 2024 05:19
@ChrisChV ChrisChV merged commit e118eb5 into openedx:master Nov 5, 2024
7 checks passed
@ChrisChV ChrisChV deleted the navin/hide-transcripts-for-lib branch November 5, 2024 20:15
navinkarkera added a commit to open-craft/frontend-app-authoring that referenced this pull request Nov 6, 2024
ChrisChV pushed a commit that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bug: Change video transcript text
3 participants