View for comparing published version of library block to previous [FC-0062] #1393
Conversation
|
Thanks for the pull request, @bradenmacdonald! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
the
open-source-contribution
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1393 +/- ##
==========================================
+ Coverage 93.09% 93.10% +0.01%
==========================================
Files 1047 1050 +3
Lines 20138 20169 +31
Branches 4201 4270 +69
==========================================
+ Hits 18748 18779 +31
+ Misses 1328 1325 -3
- Partials 62 65 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
👍 one type nit, but otherwise looks and works great!
- I tested this using the PR test instructions
- I read through the code
- I checked for accessibility issues by using my keyboard to navigate
- Includes documentation
- User-facing strings are extracted for translation
Description
This implements in an iframe a very simple view for comparing an old version of a library component with the latest published version. Currently, it's only used by a modal in the legacy UI but soon it will also be used on the Unit page in this MFE.
The part in red is implemented in this MFE PR, and the surrounding modal and buttons are part of the legacy UI (for simpler implementation and better UX consistency)
Supporting information
Part of #1341
Testing instructions
Test along with the platform PR - see instructions in openedx/edx-platform#35669
Other information
Private ref: FAL-3879