-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fixed height for prerequisite course dropdown list #1154
feat: fixed height for prerequisite course dropdown list #1154
Conversation
Thanks for the pull request, @khudym! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1154 +/- ##
==========================================
- Coverage 92.68% 92.22% -0.47%
==========================================
Files 693 1008 +315
Lines 12347 18514 +6167
Branches 2693 3958 +1265
==========================================
+ Hits 11444 17074 +5630
- Misses 872 1371 +499
- Partials 31 69 +38 ☔ View full report in Codecov by Sentry. |
@openedx/2u-tnl following up on this! |
@khudym is there a small change that you can make to restart the test check. It appears to be stalled. |
Head branch was pushed to by a user without write access
7a5646b
to
6e59368
Compare
6e59368
to
ff71b6e
Compare
Co-authored-by: Kyrylo Hudym-Levkovych <[email protected]>
Description
Note: same height is set for the course language dropdown list.
Steps to reproduce
contentstore.new_studio_mfe.use_new_grading_page
(in /admin/waffle/flag);studio -> Settings -> Schedule & details
;BEFORE
Drop-down list goes beyond footer
AFTER
Drop-down list has the same height as Course language
Course language example