style: Some nits on the code

openedx · Dec 4, 2024 · bb90f0b · bb90f0b
1 parent d92ea86
commit bb90f0b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/src/generic/toast-context/index.test.tsx b/src/generic/toast-context/index.test.tsx
@@ -9,7 +9,6 @@ export interface WraperProps {
   children: React.ReactNode;
 }
 
-// eslint-disable-next-line react/prop-types
 const TestComponentToShow = () => {
   const { showToast } = React.useContext(ToastContext);
 

diff --git a/src/library-authoring/library-team/LibraryTeam.test.tsx b/src/library-authoring/library-team/LibraryTeam.test.tsx
@@ -211,7 +211,7 @@ describe('<LibraryTeam />', () => {
   it('shows error', async () => {
     const url = getLibraryTeamApiUrl(libraryId);
     const axiosMock = new MockAdapter(getAuthenticatedHttpClient());
-    axiosMock.onPost(url).reply(400, { error: 'Error' });
+    axiosMock.onPost(url).reply(400, {});
 
     await renderLibraryTeam();
 

diff --git a/src/library-authoring/library-team/LibraryTeam.tsx b/src/library-authoring/library-team/LibraryTeam.tsx
@@ -66,8 +66,8 @@ const LibraryTeam: React.FC<Record<never, never>> = () => {
       }).then(() => {
         showToast(intl.formatMessage(messages.addMemberSuccess));
       }).catch((addMemberError) => {
-        const errorData = addMemberError.response.data;
-        if ('email' in errorData) {
+        const errorData = typeof addMemberError === 'object' ? addMemberError.response?.data : undefined;
+        if (errorData && 'email' in errorData) {
           showToast(intl.formatMessage(messages.addMemberEmailError));
         } else {
           showToast(intl.formatMessage(messages.addMemberError));