fix: set src image to a relative path

openedx · Nov 11, 2024 · 8588bc9 · 8588bc9
1 parent 9c189e4
commit 8588bc9
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/src/editors/sharedComponents/ImageUploadModal/index.jsx b/src/editors/sharedComponents/ImageUploadModal/index.jsx
@@ -21,12 +21,17 @@ export const imgProps = ({
   selection,
   lmsEndpointUrl,
   editorType,
+  isLibrary,
 }) => {
   let url = selection?.externalUrl;
   if (url?.startsWith(lmsEndpointUrl) && editorType !== 'expandable') {
     const sourceEndIndex = lmsEndpointUrl.length;
     url = url.substring(sourceEndIndex);
   }
+  if (isLibrary) {
+    const index = url.indexOf('static/');
+    url = url.substring(index);
+  }
   return {
     src: url,
     alt: settings.isDecorative ? '' : settings.altText,
@@ -36,13 +41,14 @@ export const imgProps = ({
 };
 
 export const saveToEditor = ({
-  settings, selection, lmsEndpointUrl, editorType, editorRef,
+  settings, selection, lmsEndpointUrl, editorType, editorRef, isLibrary,
 }) => {
   const newImgTag = module.hooks.imgTag({
     settings,
     selection,
     lmsEndpointUrl,
     editorType,
+    isLibrary,
   });
 
   editorRef.current.execCommand(
@@ -130,6 +136,7 @@ const ImageUploadModal = ({
   images,
   editorType,
   lmsEndpointUrl,
+  isLibrary,
 }) => {
   if (selection && selection.externalUrl) {
     return (
@@ -148,6 +155,7 @@ const ImageUploadModal = ({
             setSelection,
             lmsEndpointUrl,
             clearSelection,
+            isLibrary,
           }),
           returnToSelection: clearSelection,
         }}
@@ -190,6 +198,7 @@ ImageUploadModal.propTypes = {
   images: PropTypes.shape({}).isRequired,
   lmsEndpointUrl: PropTypes.string.isRequired,
   editorType: PropTypes.string,
+  isLibrary: PropTypes.string,
 };
 
 export const ImageUploadModalInternal = ImageUploadModal; // For testing only

diff --git a/src/editors/sharedComponents/TinyMceWidget/__snapshots__/index.test.jsx.snap b/src/editors/sharedComponents/TinyMceWidget/__snapshots__/index.test.jsx.snap
@@ -77,6 +77,7 @@ exports[`TinyMceWidget snapshots SourcecodeModal is not rendered 1`] = `
         ],
       }
     }
+    isLibrary={true}
     isOpen={false}
     lmsEndpointUrl="http://localhost:18000"
     selection="hooks.selectedImage.selection"
@@ -146,6 +147,7 @@ exports[`TinyMceWidget snapshots renders as expected with default behavior 1`] =
         ],
       }
     }
+    isLibrary={true}
     isOpen={false}
     lmsEndpointUrl="http://localhost:18000"
     selection="hooks.selectedImage.selection"

diff --git a/src/editors/sharedComponents/TinyMceWidget/index.jsx b/src/editors/sharedComponents/TinyMceWidget/index.jsx
@@ -63,6 +63,7 @@ const TinyMceWidget = ({
           images={imagesRef}
           editorType={editorType}
           lmsEndpointUrl={getConfig().LMS_BASE_URL}
+          isLibrary
           {...imageSelection}
         />
       )}