fix: linter problems

openedx · Apr 5, 2024 · 7130c0e · 7130c0e
1 parent 8fca777
commit 7130c0e
Show file tree

Hide file tree

Showing 3 changed files with 49 additions and 49 deletions.
diff --git a/src/generic/Loading.jsx b/src/generic/Loading.jsx
@@ -3,7 +3,7 @@ import PropTypes from 'prop-types';
 import { Spinner } from '@openedx/paragon';
 import { FormattedMessage } from '@edx/frontend-platform/i18n';
 
-export const LoadingSpinner = ({ size}) => (
+export const LoadingSpinner = ({ size }) => (
   <Spinner
     animation="border"
     role="status"
@@ -21,11 +21,11 @@ export const LoadingSpinner = ({ size}) => (
 
 LoadingSpinner.defaultProps = {
   size: undefined,
-}
+};
 
-LoadingSpinner.prototype = {
-  size: PropTypes.string
-}
+LoadingSpinner.propTypes = {
+  size: PropTypes.string,
+};
 
 const Loading = () => (
   <div className="d-flex justify-content-center align-items-center flex-column vh-100">

diff --git a/src/studio-home/tabs-section/courses-tab/courses-filters/index.jsx b/src/studio-home/tabs-section/courses-tab/courses-filters/index.jsx
@@ -2,7 +2,7 @@ import { useState, useCallback } from 'react';
 import { useSelector } from 'react-redux';
 import PropTypes from 'prop-types';
 import { SearchField } from '@openedx/paragon';
-import debounce from 'lodash.debounce';
+import { debounce } from 'lodash';
 
 import { getStudioHomeCoursesParams } from '../../../data/selectors';
 import { updateStudioHomeCoursesCustomParams } from '../../../data/slice';
@@ -12,16 +12,16 @@ import CoursesTypesFilterMenu from './courses-types-filter-menu';
 import CoursesOrderFilterMenu from './courses-order-filter-menu';
 import './index.scss';
 
-/*regex to check if a string has only whitespace
+/* regex to check if a string has only whitespace
   example "    "
 */
 const regexOnlyWhiteSpaces = /^\s+$/;
 
-const CoursesFilters = ({ 
-  dispatch, 
-  locationValue, 
+const CoursesFilters = ({
+  dispatch,
+  locationValue,
   onSubmitSearchField,
-  isLoading 
+  isLoading,
 }) => {
   const studioHomeCoursesParams = useSelector(getStudioHomeCoursesParams);
   const {
@@ -90,51 +90,51 @@ const CoursesFilters = ({
 
   const handleSearchCourses = (searchValueDebounced) => {
     const valueFormatted = searchValueDebounced.trim();
-      const searchValueRequest = valueFormatted.length > 0 ? valueFormatted : undefined;
-      const filterParams = {
-        search: searchValueRequest,
-        activeOnly,
-        archivedOnly,
-        order,
-      };
-      const hasOnlySpaces = regexOnlyWhiteSpaces.test(searchValueDebounced);
-
-      if (searchValueRequest && valueFormatted !== search && !hasOnlySpaces && !cleanFilters) {
-        dispatch(updateStudioHomeCoursesCustomParams({
-          currentPage: 1,
-          isFiltered: true,
-          cleanFilters: false,
-          ...filterParams,
-        }));
-  
-        dispatch(fetchStudioHomeData(locationValue, false, { page: 1, ...filterParams }, true));
-      }
-
-      setInputSearchValue(searchValueDebounced);
+    const searchValueRequest = valueFormatted.length > 0 ? valueFormatted : undefined;
+    const filterParams = {
+      search: searchValueRequest,
+      activeOnly,
+      archivedOnly,
+      order,
+    };
+    const hasOnlySpaces = regexOnlyWhiteSpaces.test(searchValueDebounced);
+
+    if (searchValueRequest && valueFormatted !== search && !hasOnlySpaces && !cleanFilters) {
+      dispatch(updateStudioHomeCoursesCustomParams({
+        currentPage: 1,
+        isFiltered: true,
+        cleanFilters: false,
+        ...filterParams,
+      }));
+
+      dispatch(fetchStudioHomeData(locationValue, false, { page: 1, ...filterParams }, true));
+    }
+
+    setInputSearchValue(searchValueDebounced);
   };
 
   const handleSearchCoursesDebounced = useCallback(
     debounce((value) => handleSearchCourses(value), 400),
-    []
+    [],
   );
 
   return (
     <div className="d-flex">
       <div className="d-flex flex-row">
-          <SearchField
-            onSubmit={onSubmitSearchField}
-            onChange={handleSearchCoursesDebounced}
-            value={cleanFilters ? '' : inputSearchValue}
-            className="mr-4"
-            data-testid="input-filter-courses-search"
-            placeholder="Search"
-            onClear={handleClearSearchInput}
-          />
-          {isLoading && (
-            <span className="search-field-loading">
-              <LoadingSpinner size="sm" />
-            </span>)
-          }
+        <SearchField
+          onSubmit={onSubmitSearchField}
+          onChange={handleSearchCoursesDebounced}
+          value={cleanFilters ? '' : inputSearchValue}
+          className="mr-4"
+          data-testid="input-filter-courses-search"
+          placeholder="Search"
+          onClear={handleClearSearchInput}
+        />
+        {isLoading && (
+          <span className="search-field-loading">
+            <LoadingSpinner size="sm" />
+          </span>
+        )}
       </div>
 
       <CoursesTypesFilterMenu onItemMenuSelected={handleMenuFilterItemSelected} />
@@ -153,7 +153,7 @@ CoursesFilters.propTypes = {
   dispatch: PropTypes.func.isRequired,
   locationValue: PropTypes.string,
   onSubmitSearchField: PropTypes.func,
-  isProcessing: PropTypes.bool,
+  isLoading: PropTypes.bool,
 };
 
 export default CoursesFilters;
diff --git a/src/studio-home/tabs-section/courses-tab/index.jsx b/src/studio-home/tabs-section/courses-tab/index.jsx
@@ -112,7 +112,7 @@ const CoursesTab = ({
       />
     ) : (
       <div className="courses-tab-container">
-        {/*isShowProcessing && <ProcessingCourses />*/}
+        {isShowProcessing && !isEnabledPagination && <ProcessingCourses />}
         {isEnabledPagination && (
           <div className="d-flex flex-row justify-content-between my-4">
             <CoursesFilters dispatch={dispatch} locationValue={locationValue} isLoading={isLoading} />