fix: use paragon branding variables for colors #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 81.01% // Head: 81.01% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #681 +/- ##
=======================================
Coverage 81.01% 81.01%
=======================================
Files 86 86
Lines 1849 1849
Branches 522 522
=======================================
Hits 1498 1498
Misses 336 336
Partials 15 15 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
arbrandes
requested changes
Nov 22, 2022
src/sass/_style.scss
Outdated
| @@ -393,7 +393,7 @@ select.form-control { | |||
| line-height: 1.25rem; | |||
| overflow-y: scroll; | |||
| position: absolute; | |||
| background-color: #fff; | |||
| background-color: white; | |||
There was a problem hiding this comment.
Do you mind using $white here and elsewhere?
17 tasks
shahbaz-shabbir05
force-pushed
the
VAN-1163
branch
from
62c5dc8 to
b17f719
Compare
|
Update: Waiting for UX to approve the color changes. |
3 tasks
shahbaz-shabbir05
force-pushed
the
VAN-1163
branch
from
b17f719 to
17e66d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have branding issue in our repo. We are hardcoding branding colors in different parts of our code.
Now, we are using paragon branding variables instead of hardcoding the colors.
Tickets: VAN-1163