Skip to content

Commit

Permalink
fix: Serialize list problem_check results as JSON
Browse files Browse the repository at this point in the history
Prior to this fix, TinCan would use the repr of the list, which
made some responses effectively un-parseable downstream.
  • Loading branch information
bmtcril committed Nov 7, 2023
1 parent b32afcd commit 9847748
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,14 @@ Change Log
Unreleased
~~~~~~~~~~

[7.0.2]

* Ensure lists of answers in problem_check are properly serialized to JSON so they
can be parsed downstream

**Note: Old events cannot be updated, the log must be replayed (if possible).**

[7.0.1]

* Do not send events for unknown courses
Expand Down
2 changes: 1 addition & 1 deletion event_routing_backends/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
Various backends for receiving edX LMS events..
"""

__version__ = '7.0.1'
__version__ = '7.0.2'
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ def get_result(self):
# to how few and how old those events are and how complicated the
# parsing is. Should we ever find it necessary to make a better
# parser for them, Insights had a good effort here:
# https://github.com/openedx/edx-analytics-pipeline/blob/master/edx/analytics/tasks/insights/answer_dist.py#L260C36-L260C36
# https://github.com/openedx/edx-analytics-pipeline/blob/8d96f93/edx/analytics/tasks/insights/answer_dist.py#L260C36-L260C36
response = event_data.get('answers', None)
correct = self.get_data('success') == 'correct'

Expand Down

0 comments on commit 9847748

Please sign in to comment.