fix: event_tracking_backends_config must use the provided plugin sett…

…ings instead of global django.conf.settings
openedx · Jun 13, 2024 · 47c25fb · 47c25fb
1 parent a415ee7
commit 47c25fb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/event_routing_backends/settings/common.py b/event_routing_backends/settings/common.py
@@ -200,6 +200,7 @@ def plugin_settings(settings):
     )
 
     settings.EVENT_TRACKING_BACKENDS.update(event_tracking_backends_config(
+        settings,
         settings.EVENT_TRACKING_BACKENDS_ALLOWED_XAPI_EVENTS,
         settings.EVENT_TRACKING_BACKENDS_ALLOWED_CALIPER_EVENTS,
     ))
diff --git a/event_routing_backends/utils/settings.py b/event_routing_backends/utils/settings.py
@@ -4,10 +4,8 @@
 
 from typing import List
 
-from django.conf import settings
 
-
-def event_tracking_backends_config(allowed_xapi_events: List[str], allowed_caliper_events: List[str]) -> dict:
+def event_tracking_backends_config(settings, allowed_xapi_events: List[str], allowed_caliper_events: List[str]) -> dict:
     """
     Return the recommended settings.EVENT_TRACKING_BACKENDS configuration.