build: local event producer #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveagent57
force-pushed
the
aed/local-events
branch
from
c6ccc21 to
d62e033
Compare
3 tasks
iloveagent57
force-pushed
the
aed/local-events
branch
2 times, most recently
from
fc539dd to
6f38279
Compare
iloveagent57
changed the title
iloveagent57
force-pushed
the
aed/local-events
branch
from
6f38279 to
43afc57
Compare
Install event-bus packages for local usage. Adds a `produce_enterprise_ping_event` mgmt command for local testing/demos of interservice event pub-sub. ENT-8761
iloveagent57
force-pushed
the
aed/local-events
branch
from
43afc57 to
21e953f
Compare
pwnage101
reviewed
May 14, 2024
Comment on lines
+41
to
+47
| # Define a Signal with the type (unique name) of the event to process, | ||
| # and tell it about the expected schema of event data. The producer of our ping events | ||
| # should emit an identical signal (same event_type and data schema). | ||
| ENTERPRISE_PING_SIGNAL = OpenEdxPublicSignal( | ||
| event_type="org.openedx.enterprise.core.ping.v1", | ||
| data=ENTERPRISE_PING_DATA_SCHEMA | ||
| ) |
There was a problem hiding this comment.
Are we going to define more than a small base set of signals in every repo, or is the idea they can be defined DRY in a shared repo?
There was a problem hiding this comment.
These signals are really for demo/testing purposes - our production-use signals will be defined in openedx-events: openedx/openedx-events#347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requires openedx/enterprise-access#468.
Installs openedx-events, kafka, and so forth for local development of kafka events. Upgrades deps due to installation of events packages. Provides example of brining the kafka broker up and producing a test/ping event.
ENT-8761
See the additions to the README for how to test this locally.
Merge checklist