Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn if we're missing a schedule for relative dates #68

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

mikix
Copy link
Contributor

@mikix mikix commented Jan 14, 2021

It happens for legitimate reasons like staff users viewing a course they are not enrolled in.

If edx-platform cares about it, they can check on their side (and thus just log once instead of many times).

@mikix mikix force-pushed the mikix/no-schedule branch from 39f6e28 to 5b7f25d Compare January 15, 2021 15:31
It happens for legitimate reasons like staff users viewing a
course they are not enrolled in.

If edx-platform cares about it, they can check on their side (and
thus just log once instead of many times).
@mikix mikix force-pushed the mikix/no-schedule branch from 5b7f25d to 3f1edcc Compare January 15, 2021 15:33
@mikix mikix changed the title Add schedule_expected argument to get_dates_for_course Don't warn if we're missing a schedule for relative dates Jan 15, 2021
@mikix mikix marked this pull request as ready for review January 15, 2021 15:35
@mikix mikix merged commit 4b3610c into master Jan 15, 2021
@mikix mikix deleted the mikix/no-schedule branch January 15, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants