Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix schedules for user view. #29

Merged
merged 1 commit into from
Feb 28, 2020
Merged

fix schedules for user view. #29

merged 1 commit into from
Feb 28, 2020

Conversation

awaisdar001
Copy link
Contributor

@awaisdar001 awaisdar001 commented Feb 28, 2020 •
edited
Loading

Description:
This PR handles a case when a user doesn't have a schedule associated with his enrollment. This will make the code more robust by handing this edge case and return None.

JIRA:
Reports of Extensions Button Not Working

Merge deadline: As soon as possible.

instructions.

Testing instructions:

  1. Go to Extensions tab on the instructor dashboard.
  2. Given that the schedule does not exist for a user for his course enrollment. Fill in the data for Individual due to date extensions form and hit Change due date...
  3. After the fix, this should pass and get a successful message.

Reviewers:

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed
  • PR author is listed in AUTHORS

Post merge:

  • Create a tag
  • Check new version is pushed to PyPi after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

@awaisdar001 awaisdar001 force-pushed the aj/fix-schedule-for-user branch 2 times, most recently from 1073c5f to 7476815 Compare February 28, 2020 17:50
cpennington
cpennington reviewed Feb 28, 2020
View reviewed changes
Copy link
Contributor

@cpennington cpennington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure to bump the version

@awaisdar001 awaisdar001 force-pushed the aj/fix-schedule-for-user branch from 7476815 to 0792d44 Compare February 28, 2020 17:59
@awaisdar001
Copy link
Contributor Author

Be sure to bump the version

Got it, Just pushed the change to bump the version in init.py file.

@awaisdar001 awaisdar001 force-pushed the aj/fix-schedule-for-user branch from 0792d44 to 4343080 Compare February 28, 2020 18:01
@awaisdar001 awaisdar001 merged commit dda617d into master Feb 28, 2020
@awaisdar001 awaisdar001 deleted the aj/fix-schedule-for-user branch February 28, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpennington cpennington cpennington approved these changes

@davestgermain davestgermain Awaiting requested review from davestgermain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@awaisdar001 @cpennington