chore: Switch from edx-sphinx-theme to sphinx-book-theme #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, @xitij2000! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
the
open-source-contribution
xitij2000
force-pushed
the
kshitij/switch-to-sphinx-book-theme
branch
2 times, most recently
from
61c07a2 to
448a4ea
Compare
xitij2000
force-pushed
the
kshitij/switch-to-sphinx-book-theme
branch
from
448a4ea to
b39adf0
Compare
|
@xitij2000 FYI, the tests are failing due to codecov issue. |
|
👍
|
xitij2000
force-pushed
the
kshitij/switch-to-sphinx-book-theme
branch
3 times, most recently
from
ffc921f to
87809d0
Compare
The edx-sphinx theme is being deprecated, and replaced with sphinx-book-theme. This removes references to the deprecated theme and replaces them with the new standard theme for the platform. See https://github.com/openedx/edx-sphinx-theme/issues/184
feanil
force-pushed
the
kshitij/switch-to-sphinx-book-theme
branch
from
87809d0 to
9064696
Compare
feanil
approved these changes
Apr 25, 2023
|
@xitij2000 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The edx-sphinx theme is being deprecated, and replaced with sphinx-book-theme. This removes references to the deprecated theme and replaces them with the new standard theme for the platform.
Testing instructions:
make docsand see that the docs are generated properly and use the sphinx-book-themeSee openedx/public-engineering#200