feat: add ai translations as a translation provider #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #544 +/- ##
==========================================
+ Coverage 94.56% 94.57% +0.01%
==========================================
Files 31 32 +1
Lines 3165 3171 +6
Branches 122 122
==========================================
+ Hits 2993 2999 +6
Misses 154 154
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jansenk
requested review from
BrandonHBodine,
Rodra,
nsprenkle,
hajorg and
KristinAoki
BrandonHBodine
requested changes
Dec 2, 2024
There was a problem hiding this comment.
I don't think this will work without updating the line at
Line 385 in 11521db
|
|
||
| CHOICES = ( | ||
| (CUSTOM, CUSTOM), | ||
| (THREE_PLAY_MEDIA, THREE_PLAY_MEDIA), | ||
| (CIELO24, CIELO24), | ||
| ) | ||
|
|
||
| # Choices specififcally for only the VideoTranscript model |
There was a problem hiding this comment.
Isn't the CHOICES enumeration already isolated to the VideoTranscript model?
There was a problem hiding this comment.
TranscriptPreference and ThirdPartyTranscriptCredentialsState also use this model
BrandonHBodine
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
edx_ai_translationsas a transcript provider optionI didn't want it to also be an option for TranscriptPreference.provider or ThirdPartyTranscriptCredentialsState.provier at this point .... potentially in the future?