Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove outdated constraints #278

Merged
merged 2 commits into from
Jun 7, 2023
Merged

chore: remove outdated constraints #278

merged 2 commits into from
Jun 7, 2023

Conversation

robrap
Copy link
Contributor

@robrap robrap commented Jun 6, 2023

Description:

Remove all outdated dependency constraints.

Note: Readthedocs builds are currently failing, and this should fix them.

robrap and others added 2 commits June 6, 2023 16:46
Copy link
Contributor

@nedbat nedbat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could quibble over the conventional commit labels (chore is for automatable work), but good to merge!

@robrap robrap merged commit 46b5259 into master Jun 7, 2023
@robrap robrap deleted the robrap-patch-1 branch June 7, 2023 21:31
@robrap
Copy link
Contributor Author

robrap commented Jun 7, 2023

Thanks @nedbat. I agree, removing the constraints is probably not automatable, but my final squashed commit comment did include:

Co-authored-by: edX requirements bot [email protected]

:) But now I probably got myself in trouble for squashing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants