-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FC-0001: remove legacy waffle flags #211
Conversation
Thanks for the pull request, @dyudyunov! I've created OSPR-6637 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@dyudyunov Thank you for the contribution. Is this ready for our review? |
@natabene yes, this one is ready along with openedx/edx-ora2#1853 and openedx/edx-platform#30330 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is almost ready, but we can merge/release it after all uses have been removed. Feel free to squash when you are ready.
1293b96
to
2c97ea0
Compare
@robrap added fixup and squashed, now it's ready to be merged! 🚀 |
This is a part of openedx/public-engineering#28 BREAKING: remove all the LegacyWaffle* classes
2c97ea0
to
30d2752
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks. I am going to adjust the commit comment a little when I merge.
@dyudyunov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This is a part of openedx/public-engineering#28
Remove all the LegacyWaffle* classes