Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FC-0001: remove legacy waffle flags #211

Merged
merged 1 commit into from
May 11, 2022

Conversation

dyudyunov
Copy link
Contributor

This is a part of openedx/public-engineering#28

Remove all the LegacyWaffle* classes

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Apr 25, 2022
@openedx-webhooks
Copy link

Thanks for the pull request, @dyudyunov! I've created OSPR-6637 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs triage labels Apr 29, 2022
@natabene
Copy link

@dyudyunov Thank you for the contribution. Is this ready for our review?

@dyudyunov
Copy link
Contributor Author

@natabene yes, this one is ready along with openedx/edx-ora2#1853 and openedx/edx-platform#30330

@openedx-webhooks openedx-webhooks added awaiting prioritization and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Apr 29, 2022
CHANGELOG.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is almost ready, but we can merge/release it after all uses have been removed. Feel free to squash when you are ready.

CHANGELOG.rst Outdated Show resolved Hide resolved
@dyudyunov dyudyunov force-pushed the remove-legacy-waffles branch 2 times, most recently from 1293b96 to 2c97ea0 Compare May 11, 2022 07:35
@dyudyunov
Copy link
Contributor Author

@robrap added fixup and squashed, now it's ready to be merged! 🚀

This is a part of openedx/public-engineering#28

BREAKING: remove all the LegacyWaffle* classes
Copy link
Contributor

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks. I am going to adjust the commit comment a little when I merge.

@robrap robrap merged commit fedeafb into openedx:master May 11, 2022
@openedx-webhooks
Copy link

@dyudyunov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@dyudyunov dyudyunov deleted the remove-legacy-waffles branch May 12, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants