-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add timing for results filtering #142
Merged
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
966e1e1
feat: add timing for resultings filtering
davidnuon aaa4372
feat: Add search timings to segment events
davidnuon 820344b
feat: Add more timing data to search
davidnuon 8542dda
feat: add filter generation measuring
davidnuon 15ab745
fix: Remove unavailable field
davidnuon dcb77de
fix: remove timing information from event
davidnuon ab3ae13
fix: import order
davidnuon 2a54da3
fix: undo comma removal
davidnuon c56745e
feat: Use eventracker in api.py instead of logging
davidnuon 65a9d4e
fix: fix typo
davidnuon d2e29e0
feat: Refactored timing logic to its own class
davidnuon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please wrap all these into a separate function? That way, we can add a set of unit test to ensure the calculation and event sending