-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract opaque_keys into a separate library #3862
Conversation
👍 assuming tests pass |
@cpennington When running this branch locally, |
besides that, 🎋 🍊 ⛵ |
@clytwynec we need to look into this ^ (paver install_prereqs issue) |
@jzoldak @clytwynec -- another thing I notice is that paver install_prereqs is run 3x times during the unit test suite. I think it would be worth making it so that does not happen (right now we're just chaining calls to run different suites of tests, each of which first calls install_prereqs). |
oh, right the install prereqs not picking up would be fixed if we merge in #3487 ? |
This PR should now include the updates from #3487 |
👍 |
@cpennington it doesn't seem to have the updates from #3487 ? in particular github.txt still isn't included in pavelib, so I'm still seeing the install_prereqs issue |
(are we still planning to merge #3487 separately...?) |
@flowerhack ? #3487 was merged... |
whups, forgot to pull. @cpennington it works fine now |
The failed test is known to be intermittent. Merging. |
Extract opaque_keys into a separate library
No description provided.