-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show math in plain text in library cards #36055
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @navinkarkera! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
72612db
to
666d272
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this change @navinkarkera ! It's quite clean, considering all the things that it does!
I found one bug, and left a couple other suggestions which you can choose to ignore :)
71550be
to
a335a9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 This looks great and very thorough.
- I tested this: did the testing instructions with different mathjax code
- I read through the code
- I checked for accessibility issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Just some minor concerns around \mathbf
but everything else is good to go.
48ad916
to
019609c
Compare
Do not convert it partially
de9bc3e
to
2def856
Compare
The CI is failing due to some issue with docker login. |
Description
Converts mathjax equations to unicode to be rendered as plain text in library card previews.
Useful information to include:
Screenshot:
Supporting information
Private-ref
: FAL-3990Testing instructions
Notes
\frac
,\mathbf
,\bf
etc. which I have handled using replacements.\begin{bmatrix}
,\begin{cases}
etc. cannot be displayed properly in plain text so they are rendered raw.