Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade list_report_downloads api to DRF ( 13th ) #35350

Merged
merged 5 commits into from
Sep 9, 2024
Merged

feat: upgrade list_report_downloads api to DRF ( 13th ) #35350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e31b49c
feat: upgrading simple api to drf compatible.
awais786 Aug 22, 2024
9a531d0
feat: upgrading simple api to drf compatible.
awais786 Aug 22, 2024
9ce8755
Merge branch 'master' into list_report_downloads
awais786 Aug 23, 2024
3e3f3e1
Merge branch 'master' into list_report_downloads
awais786 Sep 6, 2024
6683c1c
Merge branch 'master' into list_report_downloads
awais786 Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions lms/djangoapps/instructor/views/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2540,16 +2540,22 @@ def get(self, request, course_id):
return _list_report_downloads(request=request, course_id=course_id)


@require_POST
@ensure_csrf_cookie
def list_report_downloads(request, course_id):
@method_decorator(cache_control(no_cache=True, no_store=True, must_revalidate=True), name='dispatch')
class ListReportDownloads(APIView):

"""
List grade CSV files that are available for download for this course.

Takes the following query parameters:
- (optional) report_name - name of the report
"""
return _list_report_downloads(request=request, course_id=course_id)
permission_classes = (IsAuthenticated, permissions.InstructorPermission)
permission_name = permissions.CAN_RESEARCH

@method_decorator(ensure_csrf_cookie)
def post(self, request, course_id):

return _list_report_downloads(request=request, course_id=course_id)


@cache_control(no_cache=True, no_store=True, must_revalidate=True)
Expand Down
2 changes: 1 addition & 1 deletion lms/djangoapps/instructor/views/api_urls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
path('get_proctored_exam_results', api.get_proctored_exam_results, name='get_proctored_exam_results'),

# Grade downloads...
path('list_report_downloads', api.list_report_downloads, name='list_report_downloads'),
path('list_report_downloads', api.ListReportDownloads.as_view(), name='list_report_downloads'),
path('calculate_grades_csv', api.calculate_grades_csv, name='calculate_grades_csv'),
path('problem_grade_report', api.problem_grade_report, name='problem_grade_report'),

Expand Down
Loading