-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: modify PhoneNumberSerializer regex to allow plus symbol at the … #35117
feat: modify PhoneNumberSerializer regex to allow plus symbol at the … #35117
Conversation
Thanks for the pull request, @andrey-canon! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Hi there! Thanks for your contribution. Is there any chance you could update the unit tests with this change as well? Specifically, I'm thinking we should update the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comment -- I'm requesting a tiny update to existing unit tests before accepting this change! :)
d439d77
to
d8e4d5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and thanks for reworking the old unit tests. These are much cleaner and easier to read.
I'll go ahead and merge this too.
@andrey-canon 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
openedx#35117) * feat: modify PhoneNumberSerializer regex to allow plus symbol at the beginning * chore: update PhonenumberSerializer docstring
openedx#35117) * feat: modify PhoneNumberSerializer regex to allow plus symbol at the beginning * chore: update PhonenumberSerializer docstring
Description
This modifies the current serializer regex that removes all characters that are not numbers, to allow the plus symbol at the start, This modification is made based on this comment
Testing instructions