Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "Course Number Display String" option doesn't influence certificate for Quince #34466

Conversation

DmytroAlipov
Copy link
Contributor

@DmytroAlipov DmytroAlipov commented Apr 3, 2024

This is a backport from the master.

Description

In Advanced Settings, it is possible to redefine the name for the Course Organization as well as for the Course Number. However, a bug was discovered in replacing this name on the certificate:
c_1

For Course Number Display String everything works correctly:
c_2

But the name of the organization is always taken from the Organizations model. In this case, the definition from Advanced Settings is ignored:
c_4

For other pages, the override works correctly for both settings:
c_3png

I slightly changed the logic for prioritizing the selection of the organization name for the certificate. Now everything is replaced correctly:
c_5

@openedx-webhooks
Copy link

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 3, 2024
@mphilbrick211 mphilbrick211 added waiting for eng review PR is ready for review. Review and merge it, or suggest changes. backport PR backports a change from main to a named release. labels Apr 3, 2024
@mphilbrick211 mphilbrick211 requested a review from a team April 3, 2024 19:22
"Course organization display string" option in Advanced settings
doesn't influence certificate.
@DmytroAlipov DmytroAlipov force-pushed the fix-course-org-display-string-quince branch from 226b443 to 12d3554 Compare April 5, 2024 18:20
@justinhynes
Copy link
Contributor

I took a look at the changes on the master branch and they look good, I do have an open question on the other branches PR though. I'll keep the focus of the conversation on the other PR, just commenting to let you know this PR is on my radar too.

Copy link
Contributor

@justinhynes justinhynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've approved this change in the master branch (#34465).

This should be good to go.

@justinhynes justinhynes merged commit b036cd0 into openedx:open-release/quince.master Apr 23, 2024
43 checks passed
@openedx-webhooks
Copy link

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@DmytroAlipov DmytroAlipov deleted the fix-course-org-display-string-quince branch April 23, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants