fix: "Course Number Display String" option doesn't influence certificate for Quince #34466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport from the master.
Description
In Advanced Settings, it is possible to redefine the name for the Course Organization as well as for the Course Number. However, a bug was discovered in replacing this name on the certificate:
For Course Number Display String everything works correctly:
But the name of the organization is always taken from the Organizations model. In this case, the definition from Advanced Settings is ignored:
For other pages, the override works correctly for both settings:
I slightly changed the logic for prioritizing the selection of the organization name for the certificate. Now everything is replaced correctly: