-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: respect ENABLE_NEW_STRUCTURE_DISCUSSIONS flag in course import #33975
fix: respect ENABLE_NEW_STRUCTURE_DISCUSSIONS flag in course import #33975
Conversation
Thanks for the pull request, @asadali145! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Just one silly question to answer, and then I'm willing to merge this.
@asadali145 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
This PR fixes an issue with the course import.
When a course is imported and
ENABLE_NEW_STRUCTURE_DISCUSSIONS
is disabled, it still setsDiscussionsConfiguration.provider_type = openedx
Supporting information
https://github.com/mitodl/hq/issues/3076
Testing instructions
/admin/waffle/flag/
legacy
at/admin/discussions/discussionsconfiguration/
<studio_url>/import/<course_key>
openedx
at/admin/discussions/discussionsconfiguration/
and it did not respectENABLE_NEW_STRUCTURE_DISCUSSIONS
.ENABLE_NEW_STRUCTURE_DISCUSSIONS
and discussions xBlock is available before and after course import.