Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect ENABLE_NEW_STRUCTURE_DISCUSSIONS flag in course import #33975

Conversation

asadali145
Copy link
Contributor

Description

This PR fixes an issue with the course import.

When a course is imported and ENABLE_NEW_STRUCTURE_DISCUSSIONS is disabled, it still sets DiscussionsConfiguration.provider_type = openedx

Supporting information

https://github.com/mitodl/hq/issues/3076

Testing instructions

  • Checkout master branch
  • Disable ENABLE_NEW_STRUCTURE_DISCUSSIONS at /admin/waffle/flag/
  • Create a new course in studio.
  • Verify that the provider_type is set to legacy at /admin/discussions/discussionsconfiguration/
  • Add a new unit to the course content and verify that the discussions xBlock is available.
  • Now, import a compressed file in this new course at <studio_url>/import/<course_key>
  • Verify that the provider_type is changed to openedx at /admin/discussions/discussionsconfiguration/ and it did not respect ENABLE_NEW_STRUCTURE_DISCUSSIONS.
  • Discussion xBlock is also hidden while creating a unit.
  • Now, checkout this branch and verify that the course import respected ENABLE_NEW_STRUCTURE_DISCUSSIONS and discussions xBlock is available before and after course import.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 27, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @asadali145! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link
Contributor

@arslanashraf7 arslanashraf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@pdpinch pdpinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Just one silly question to answer, and then I'm willing to merge this.

@pdpinch pdpinch merged commit ec86398 into openedx:master Jan 3, 2024
64 checks passed
@openedx-webhooks
Copy link

@asadali145 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants