-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create DRF endpoint to get course index context #33943
feat: create DRF endpoint to get course index context #33943
Conversation
Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
One thing you could do is the following: Does that make sense? There are a couple of instances in edx-platform where we do this, I could find some for you if you like. |
009ca23
to
9e48d37
Compare
@connorhaugh Thanks for the pointer. Have added a test which makes sure the number of calls to mysql and mongo same as before. Also, verified that moving |
9e48d37
to
6976d80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet -- thanks for adding those tests, it dramatically boosts confidence re-merging this pr.
@KristinAoki can you merge this on monday (for on call purposes?)
@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
Continuing the work from #32856.
This PR adds DRF endpoint for fetching course index outline content and fixes issue mentioned here: #33667 (comment)
Useful information to include:
Supporting information
Private-ref
: BB-8140Testing instructions
make {lms,cms}-up
./contentstore/v1/course_index/{course_id}
api.Try it out
option to play around with the API.