-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing function import in certificate template #33904
fix: add missing function import in certificate template #33904
Conversation
Thanks for the pull request, @kaustavb12! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Sandbox deployment successful. Sandbox LMS is available at pr-33904-139931.staging.do.opencraft.hosting Instance config : https://grove-stage-build-logs.nyc3.digitaloceanspaces.com/34602668-5720571801-config.yml |
Sandbox deployment successful. Sandbox LMS is available at pr-33904-139931.staging.do.opencraft.hosting Instance config : https://grove-stage-build-logs.nyc3.digitaloceanspaces.com/34602668-5721541352-config.yml |
👍
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thank you for this bugfix @kaustavb12 !
I'll merge this tomorrow if there are no objections. CC @mphilbrick211
- I tested this by following the PR instructions and checking the sandbox configuration.
- I read through the code
-
I checked for accessibility issuesN/A -
Includes documentationbugfix N/A -
User-facing strings are extracted for translationN/A
@kaustavb12 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
* fix: add missing function import in certificate template * test: add test case to check certificates generated when GA4 is enabled (cherry picked from commit d0a49d1)
* fix: add missing function import in certificate template * test: add test case to check certificates generated when GA4 is enabled (cherry picked from commit d0a49d1)
patch: add missing function import in certificate template (openedx#33904) See merge request hippoteam/aspen-courses/edx-platform!7
Description
Currently the default certificate template breaks during rendering if
GOOGLE_ANALYTICS_4_ID
is defined, because of a missing import.This PR fixes this issue.
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
openedx
/openedx
.googletagmanager.com
with the dummy idGTM-ABCD123
. This verifies thatGOOGLE_ANALYTICS_4_ID
is configured correctly for this sandbox.Preview Certificate
.Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Private Ref: OpenCraft Internal Ticket - BB-8212
Sandbox configuration
Settings