-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Tag List on Unit page [FC-0036] #33645
Merged
bradenmacdonald
merged 22 commits into
openedx:master
from
open-craft:chris/FAL-3527-tags-on-unit-page
Nov 17, 2023
Merged
Changes from 19 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
4a95e8d
feat: Tag List component structure
ChrisChV d8e327c
feat: Build view to pass tags to UI
ChrisChV e36cb84
feat: Building Tag list component on unit page
ChrisChV b383efe
refactor: Extract tag list as a separated component
ChrisChV a9f2afc
feat: Render tag children
ChrisChV e19ff55
feat: Manage tags button added on component menu
ChrisChV 7305ed7
chore: Lint
ChrisChV d79cf97
style: Nits
ChrisChV b423507
style: Adding comments in get_unit_tags
ChrisChV 3db38e8
Merge branch 'master' into chris/FAL-3527-tags-on-unit-page
ChrisChV b96fd33
feat: Extract open and close tagging drawer to utility functions
ChrisChV a005b34
feat: Open manage tag drawer
ChrisChV 694d164
Merge branch 'master' into chris/FAL-3527-tags-on-unit-page
ChrisChV 6d70b80
fix: Bug with multiple children on the same parent tag
ChrisChV 91c03c1
fix: caret up/down for children tags
ChrisChV 76232ba
style: Typo on comments
ChrisChV 7aa790d
style: Nits on UI
ChrisChV f19b1e8
Merge branch 'master' into chris/FAL-3527-tags-on-unit-page
ChrisChV aa12f5c
style: Nit on open taxonomy and tag
ChrisChV 29f3b9c
feat: Add a11y support to tag list component
ChrisChV d3c7603
style: Nit
ChrisChV aade38f
Merge branch 'master' into chris/FAL-3527-tags-on-unit-page
ChrisChV File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChrisChV I'm wondering if there is a way to make use of @bradenmacdonald 's updated implementation in the
openedx-learning
repo that added the lineage information to the object tags and takes care of the grouping under taxonomies as well, rather than re-implementing it here as well we could potentially utilize that as a single source of truth.Here is a sample of how the data looks like:
Though I think to make use of that, it seems there needs to be some changes made to the
openedx-learning
repo, namely extracting the logic out of theObjectTagsByTaxonomySerializer
and exposing a python API that can be used in this repo. Since currently It is only available through the rest api.Any thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thinking was that it's OK to have this duplicated here, because eventually this will be re-implemented in the course-authoring MFE and fetch data using REST (that's out of scope for us now, but at some point ALL of these Studio pages will be using the new MFE only). When that happens, it can use the logic in openedx-learning.
We should definitely put in a comment stating that when this is moved into an MFE it should be simplified to use the REST API which already provides this grouping + sorting logic. But for now since it's already implemented this way, I think it's fine to leave it like this and get it done sooner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok @bradenmacdonald, that makes sense 👍
@yusuf-musleh Adding another comment, In addition to grouping by taxonomy, it is also necessary to group by parents, to be able to assemble each level of the component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bradenmacdonald I see, yup, that make sense to me as well!
@ChrisChV Sounds good!