Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Tag Models [FC-0030] #33378

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

bradenmacdonald
Copy link
Contributor

@bradenmacdonald bradenmacdonald commented Sep 29, 2023

Description

This PR goes along with openedx/openedx-learning#87 and makes some simplifications and clean ups to the "content tagging" app.

Interestingly, I didn't have to change the views or test_views at all - those tests are all still passing with no changes.

Note: it is now a bit safer to edit these models in the Django admin, because ObjectTag now has a clean() method which performs some basic validation.

Supporting information

Issue: openedx/modular-learning#85

Testing instructions

For now just run the test suite; this app doesn't have a UI yet.

Deadline

None

Private-ref: FAL-3477

@openedx-webhooks
Copy link

Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 29, 2023
requirements/edx/base.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bradenmacdonald Looks good 👍

  • I tested this runing the test.
  • I read through the code.
  • Includes documentation

@bradenmacdonald bradenmacdonald force-pushed the braden/tagging-refactor branch from 350bc04 to 3fba862 Compare October 3, 2023 21:46
Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup 👍

  • I tested this: checked that the CI is passing
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation: n/a
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository: n/a

@bradenmacdonald bradenmacdonald merged commit 0a6eb51 into openedx:master Oct 5, 2023
61 checks passed
@bradenmacdonald bradenmacdonald deleted the braden/tagging-refactor branch October 5, 2023 16:38
@openedx-webhooks
Copy link

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants