Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing advance_settings_access template variable #32097

Merged
merged 1 commit into from
May 5, 2023
Merged

fix: missing advance_settings_access template variable #32097

merged 1 commit into from
May 5, 2023

Conversation

0x29a
Copy link
Contributor

@0x29a 0x29a commented Apr 19, 2023 •
edited
Loading

Description

Fixes the bug introduced in #32015.

To reproduce it, open any studio page, like <STUDIO>/settings/grading/<COURSE_ID> and open the Settings dropdown. You won't see the Advanced Settings button there. It's visible only at the Course Outline page.

Testing instructions

Check that Advanced Settings button is visible at any Studio page.

Notes

Merging this makes the revert PR (#32062) redundant.

private-ref

@openedx-webhooks
Copy link

Thanks for the pull request, @0x29a! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 19, 2023
@0x29a 0x29a mentioned this pull request Apr 19, 2023
Merged
@0x29a 0x29a mentioned this pull request Apr 27, 2023
Closed
@0x29a 0x29a force-pushed the 0x29a/bb7220/disable-advanced-settings branch from c5962d2 to b9d528e Compare April 27, 2023 21:00
farhaanbukhsh
farhaanbukhsh reviewed May 1, 2023
View reviewed changes
cms/djangoapps/contentstore/tests/test_course_settings.py
self.non_staff_client, _ = self.create_non_staff_authed_user_client()

self.non_staff_client, self.nonstaff = self.create_non_staff_authed_user_client()
CourseStaffRole(self.course.id).add_users(self.nonstaff)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a reason why we are doing this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

farhaanbukhsh
farhaanbukhsh approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@farhaanbukhsh farhaanbukhsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • ✅ I tested this on devstack and read through the tests.
  • ✅ I read through the code
  • ❌ I checked for accessibility issues
  • ❌ Includes documentation
  • ❌ I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@0x29a 0x29a force-pushed the 0x29a/bb7220/disable-advanced-settings branch 2 times, most recently from 938c906 to 84bedd0 Compare May 1, 2023 14:09
arslanashraf7
arslanashraf7 approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@arslanashraf7 arslanashraf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed through the code and it looks good. I couldn't test it personally because I was running errors building devstack locally but since @farhaanbukhsh has tested it already I'd pass on that.

Just a typo fix suggested.

common/djangoapps/student/auth.py Outdated
If DISABLE_ADVANCED_SETTINGS feature is enabled, only Django Superuser
or Django Staff can access "Advanced Settings".

By defeault, this feature is disabled.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
By defeault, this feature is disabled.
By default, this feature is disabled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

@0x29a 0x29a force-pushed the 0x29a/bb7220/disable-advanced-settings branch from 84bedd0 to 50854df Compare May 3, 2023 11:00
@farhaanbukhsh
Copy link
Member

I skimmed through the code and it looks good. I couldn't test it personally because I was running errors building devstack locally but since @farhaanbukhsh has tested it already I'd pass on that.

Just a typo fix suggested.

Thanks a bunch @arslanashraf7

@farhaanbukhsh
Copy link
Member

@0x29a I have added one last nit, please address that and squash your commits :)

@0x29a 0x29a force-pushed the 0x29a/bb7220/disable-advanced-settings branch from 64c7201 to a32a49c Compare May 4, 2023 13:14
@farhaanbukhsh farhaanbukhsh merged commit 065f894 into openedx:master May 5, 2023
@farhaanbukhsh farhaanbukhsh deleted the 0x29a/bb7220/disable-advanced-settings branch May 5, 2023 06:12
@openedx-webhooks
Copy link

@0x29a 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@itsjeyd itsjeyd mentioned this pull request May 10, 2023
Open
1 task
@Agrendalath Agrendalath mentioned this pull request May 24, 2023
Closed
@0x29a 0x29a mentioned this pull request May 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farhaanbukhsh farhaanbukhsh farhaanbukhsh approved these changes

@arslanashraf7 arslanashraf7 arslanashraf7 approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0x29a @openedx-webhooks @farhaanbukhsh @edx-pipeline-bot @arslanashraf7