-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove relative due date limit #32094
fix: remove relative due date limit #32094
Conversation
Thanks for the pull request, @Agrendalath! As a core committer in this repo, you can merge this once the pull request is approved per the core committer reviewer requirements and according to the agreement with your edX Champion. |
Hey @Agrendalath, I change the Can you explain the behaviour here? Thanks. |
@farhaanbukhsh, I forgot to mention it in the testing instructions, but you should rebuild Studio statics and refresh the browser's cache. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- ✅ I tested this: I have checked the artificial limit is removed and this works well in the devstack.
- ✅ I read through the code
- ❌ I checked for accessibility issues
- ❌ Includes documentation
- ❌ I made sure any change in configuration variables is reflected in the corresponding client's
configuration-secure
repository.
It was an artificial limit enforced by the frontend. The backend does not have limitations that would prevent it from using a higher value.
93697b9
to
c1a5aef
Compare
@Agrendalath 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
EdX Release Notice: This PR has been deployed to the production environment. |
1 similar comment
EdX Release Notice: This PR has been deployed to the production environment. |
Description
The due date limit is artificially enforced by the frontend. The backend does not have limitations that would prevent it from using a higher value. Having this limit leads to the bug described in the "Testing instructions".
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
999
.1024
.Deadline
"None"
Other information
Private-ref: https://tasks.opencraft.com/browse/BB-7349