fix: blocks v2 will filter discussion xblocks #31820
Conversation
muhammadadeeltajamul
force-pushed
the
inf-795
branch
from
30fcc78 to
8456500
Compare
I think waffle flag is not needed |
| if provider == Provider.OPEN_EDX and request_from_mobile: | ||
| blocks = response.data | ||
| filtered_blocks = {} | ||
| for key, value in blocks.get('blocks', {}).items(): |
There was a problem hiding this comment.
just a nit.
response.data = {key: value for key, value in blocks.get('blocks', {}).items() if value.get('type') != 'discussion'}
This is the temporary fix to stop mobile application from crashing. Is test case required for this? |
muhammadadeeltajamul
force-pushed
the
inf-795
branch
from
8456500 to
09e896a
Compare
| """ | ||
| configuration = DiscussionsConfiguration.get(context_key=course_key) | ||
| provider = configuration.provider_type | ||
| if provider == Provider.OPEN_EDX and request_from_mobile: |
There was a problem hiding this comment.
I think we do not need this request_from_mobile condition. If the provider is OPEN_EDX then we do not want to return the discussion xblocks in any case because they are no longer relevant
muhammadadeeltajamul
force-pushed
the
inf-795
branch
2 times, most recently
from
7a41b67 to
00eb281
Compare
muhammadadeeltajamul
requested review from
asadazam93
and removed request for
jawad-khan
| False, | ||
| True, | ||
| ) | ||
| def test_filter_discussion_xblocks_for_mobile(self, change_provider): |
There was a problem hiding this comment.
no need to add "for_mobile" here
There was a problem hiding this comment.
change_provider can be changed to "is_open_edx_provider" for clarity
muhammadadeeltajamul
force-pushed
the
inf-795
branch
from
00eb281 to
8e8883f
Compare
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
1 similar comment
|
EdX Release Notice: This PR has been deployed to the production environment. |
Mobile app was crashing when discussion xblock was clicked for openedx provider. This change will filter discussion xblocks from blocks v2 api when provider is openedx and request is sent from mobile