Node 16 Upgrade #30354
Node 16 Upgrade #30354
Conversation
aht007
force-pushed
the
aht007/Node-Upgrade
branch
2 times, most recently
from
3668f2f to
c5f46e8
Compare
aht007
force-pushed
the
aht007/Node-Upgrade
branch
from
68ec055 to
9af43a5
Compare
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
1 similar comment
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
EdX Release Notice: This PR has been rolled back from the production environment. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
1 similar comment
|
EdX Release Notice: This PR has been deployed to the production environment. |
| @@ -57,6 +57,7 @@ | |||
| "redux-thunk": "2.2.0", | |||
| "requirejs": "2.3.5", | |||
| "rtlcss": "2.2.1", | |||
| "sass": "^1.49.10", | |||
There was a problem hiding this comment.
@aht007 Can you help me understand why you removed node-sass and installed sass as part of this upgrade?
There was a problem hiding this comment.
node-sass has been deprecated for a long time now and we faced several issues with it when moving towards node16. Also dart-sass(sass) is the recommended replacement for it which works nicely with node16 and hence the change.
Reference Docs:
- https://2u-internal.atlassian.net/wiki/spaces/AC/pages/2626116/Node+16+Upgrade (Internal, Attaching Screenshot
There was a problem hiding this comment.
Got it, thank you!
For context, the edx-platform build pipeline still uses libsass-python (which is deprecated as well). I am currently looking into replacing with, either with node-sass or dart-sass. There's discussion in #wg-developer-experience if you're curious.
Description
This PR adds
node 16support to edx-platform and also updates the dependent packages inpackage.jsonTested these changes by creating Sandbox with Node 16 configurations as well as on Sandbox with node 12 configuration.
Related PR to move
prodto Node16 will be merged later on