Revert disable check button on save #10546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
1 similar comment
|
👍 |
adampalay
added a commit
that referenced
this pull request
Nov 6, 2015
Revert disable check button on save
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cahrens
@sarina
This PR reverts #10488 . That PR introduced a visual bug where the check button's text switched from "check" to "checking" while it was disabled: https://github.com/edx/edx-platform/blob/master/common/lib/xmodule/xmodule/js/src/capa/display.coffee#L688
The reason I'm reverting this instead of fixing it is that it looks like there could be a potential race condition with any of these buttons. Really, whenever we click one of these buttons, all of the buttons should be disabled until after the ajax call goes through.
I'm going to add this information to the original ticket: https://openedx.atlassian.net/browse/TNL-3477.
@stvstnfrd , @caesar2164 , FYIs. Thank you for raising the original issue; heads up that there's a visual bug in the original fix.
@jcdyer