Added photo_id_key while AUTOMATIC_VERIFY_STUDENT_IDENTITY_FOR_TESTING is True #10393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasawernawaz
force-pushed
the
tasawer/story/ecom-2547-set-photo-id-for-initial-verfication
branch
from
426e885
to
712fd17
Compare
| if settings.FEATURES.get('AUTOMATIC_VERIFY_STUDENT_IDENTITY_FOR_TESTING'): | ||
| self.photo_id_key = 'abc' |
There was a problem hiding this comment.
nit: self.photo_id_key = 'fake-photo-id-key'
tasawernawaz
force-pushed
the
tasawer/story/ecom-2547-set-photo-id-for-initial-verfication
branch
from
712fd17
to
2a710b2
Compare
| attempt.mark_ready() | ||
| attempt.submit() | ||
|
|
||
| assert_equals(attempt.photo_id_key, "abc") |
There was a problem hiding this comment.
Please use self.assertEqual for comparing values.
tasawernawaz
force-pushed
the
tasawer/story/ecom-2547-set-photo-id-for-initial-verfication
branch
from
55ae59e
to
565a160
Compare
| @@ -647,6 +647,9 @@ def upload_photo_id_image(self, img_data): | |||
| # verification functionality. If you do want to work on it, you have to | |||
| # explicitly enable these in your private settings. | |||
| if settings.FEATURES.get('AUTOMATIC_VERIFY_STUDENT_IDENTITY_FOR_TESTING'): | |||
| # fake photo id key is set only for initial reverification | |||
There was a problem hiding this comment.
nit: initial verification
…G is True ECOM-2547
tasawernawaz
force-pushed
the
tasawer/story/ecom-2547-set-photo-id-for-initial-verfication
branch
from
565a160
to
982c9a2
Compare
|
lgtm 👍 |
|
@edx/ecommerce Please review this. |
|
jenkins run bokchoy |
1 similar comment
|
jenkins run bokchoy |
|
@clintonb Please review this. |
|
👍 |
tasawernawaz
pushed a commit
that referenced
this pull request
Oct 28, 2015
…id-for-initial-verfication Added photo_id_key while AUTOMATIC_VERIFY_STUDENT_IDENTITY_FOR_TESTING is True
benpatterson
deleted the
tasawer/story/ecom-2547-set-photo-id-for-initial-verfication
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
photo_id_keyis required so dummy value is added whenAUTOMATIC_VERIFY_STUDENT_IDENTITY_FOR_TESTINGflag isTrue.ECOM-2547
@awais786 @afeef @zubair-arbi @ahsan-ul-haq